Implement unique request IDs across threads #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how are we testing this right now? Manually? |
@nv-hwoo will/is testing it manually and we'll also deliver the build to @pskiran1 to test. |
tgerdesnv
reviewed
Dec 4, 2023
nv-hwoo
approved these changes
Dec 5, 2023
|
offline @pskiran1 stated that his manual testing worked. This is good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes the thread ID and sets that to the upper 16 bits of the 64-bit-converted-to-string request ID. Takes the thread-local request ID and sets that to the lower 48 bits.